fix(ftxui): bump port-version 4→5 补 PR #38 遗漏 + add-tui-hyperlinks 收尾文档 - #39
Open
LIUXIN557 wants to merge 2 commits into
Open
fix(ftxui): bump port-version 4→5 补 PR #38 遗漏 + add-tui-hyperlinks 收尾文档#39LIUXIN557 wants to merge 2 commits into
LIUXIN557 wants to merge 2 commits into
Conversation
PR #38 only moved the submodule gitlink to f98588b4 (hover patch head) but left ports/ftxui/vcpkg.json at port-version 4. Per the rule in portfile.cmake, vcpkg computes its ABI hash from vcpkg.json alone and never re-reads the sources under SOURCE_PATH, so any incremental build with an existing vcpkg_installed would silently keep using the old ftxui and fail to compile (EnableMouseHoverMotion not a member of ftxui::App). Bump to 5 so the hash is invalidated and the rebuilt ftxui 7.0.3#5 (with the hover patch) is actually picked up.
…docs tasks.md: tick 6.1-6.3 with verification notes (gitlink landed via PR #38, local rebuild ftxui 7.0.3#5 + full unit run 3766 pass / 9 known baseline failures -> zero regression, openspec validate --strict passed). New verification-checklist.md (iTerm2 x15 / Terminal.app x4 / Windows Terminal x4 matrix mapped from spec scenarios) and manual-test-cases.md (B1-B6 prompt + expected-render + action pairs for real-terminal checks). Note: openspec/ is gitignored at repo root; these files are force-added, consistent with existing tracked openspec changes (dbcdf45).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
PR #38（
bbe73202）将external/ftxuigitlink 前移至f98588b4（hover 补丁头，修复 master 构建），但漏了同步 bumpports/ftxui/vcpkg.json的 port-version。按
portfile.cmake明文规则：vcpkg 的 ABI hash 只由portfile.cmake+vcpkg.json计算，从不读 SOURCE_PATH 下的源码——gitlink 变更若不 bump port-version，任何带 vcpkg 缓存的增量构建都会静默沿用旧 ftxui，报EnableMouseHoverMotion is not a member of ftxui::App（本地已实测踩坑）。master 当前 port-version=4 正是这个隐患状态。改动
提交 1 —
fix(ftxui): bump port-version 4→5ports/ftxui/vcpkg.json：port-version 4→5，使 vcpkg ABI hash 失效并重建带 hover 补丁的ftxui 7.0.3#5。提交 2 —
docs(openspec): add-tui-hyperlinks 收尾openspec/changes/add-tui-hyperlinks/tasks.md：勾选 6.1–6.3（附验证备注：本地重编 390 单元通过、全量单测 3766 PASS / 9 失败 == 基线零回归、openspec validate --strict通过）verification-checklist.md：6.4/6.5 人工验收矩阵（iTerm2×15 / Apple Terminal.app×4 / Windows Terminal×4，按 spec 场景逐条映射）manual-test-cases.md：B1–B6 真机验收提示词+用例手册.gitignore忽略openspec/，新文件按既有惯例 force-add（同dbcdf45d）验证
7.0.3#5全量重建 + 单测零回归（09-02 完成）openspec validate add-tui-hyperlinks --strict→ Change is valid待办（不属于本 PR）